[FFmpeg-devel] [PATCH v2] ogg/vorbis: implement header packet skip in chained ogg bitstreams.

Michael Niedermayer michael at niedermayer.cc
Mon Aug 4 11:21:33 EEST 2025


Hi Romain

On Mon, Aug 04, 2025 at 02:11:03AM +0200, Michael Niedermayer wrote:
> Hi Romain
> 
> On Sun, Aug 03, 2025 at 05:50:17PM -0500, Romain Beauxis wrote:
> > Le dim. 3 août 2025 à 16:36, Michael Niedermayer
> > <michael at niedermayer.cc> a écrit :
> [...]
> > > > Do you have any advice on how to look for a reviewer for this path?
> > >
> > > social media, like twitter
> > >
> > > also if it has a positive vibe then we can retweet
> > 
> > Respectfully, this does not make sense to me.
> 
> i dont have time ATM, and it seems the others also are overloaded
> 
> -> so the goal is to attract more reviewing manpower
> 
> but surely eventually someone will have time and look at it
> also this is not the most trivial patchset

I ve reviewed your patch on https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20026 now

you ignored review comments made previously

The patch also contained a trivial mistake:
(maybe review your own code if you have time and reviewers are all busy)
(also as said previously (IIRC) if reviewers are all busy, help review other peoples
 patches)
        priv->comment_size = 0;
        av_freep(&priv->setup);
        priv->comment_size = 0;

Also its summer vacation time and everyone is busy

thx

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Some Animals are More Equal Than Others. - George Orwell's book Animal Farm
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20250804/b498119e/attachment.sig>


More information about the ffmpeg-devel mailing list