[FFmpeg-devel] [PATCH v3] examples: Add check and replace av_free() to avoid potential memory errors
Michael Niedermayer
michael at niedermayer.cc
Thu Aug 7 03:26:45 EEST 2025
On Wed, Aug 06, 2025 at 04:56:42PM +0200, Nicolas George wrote:
> Jiasheng Jiang (HE12025-08-06):
> > Add check for the return value of av_packet_alloc() to avoid potential NULL pointer dereference.
> > Moreover, replace redundant av_free() with fprintf().
> >
> > Fixes: 9a38184a14 ("examples/decode_audio: allocate the packet dynamically")
> > Signed-off-by: Jiasheng Jiang <jiashengjiangcool at gmail.com>
> > ---
> > Changelog:
> >
> > v2 -> v3:
> >
> > 1. Remove wrong Fixes tag.
> >
> > v1 -> v2:
> >
> > 1. Remove unnecessary goto.
> > 2. Add fprintf() for error message.
> > ---
> > doc/examples/decode_audio.c | 6 +++++-
> > 1 file changed, 5 insertions(+), 1 deletion(-)
>
> Still looks good to me, of course, thanks.
>
> I do not maintain the docs.
will apply
thx for review
[...]
--
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
Whats the most studid thing your enemy could do ? Blow himself up
Whats the most studid thing you could do ? Give up your rights and
freedom because your enemy blew himself up.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20250807/6e09d962/attachment.sig>
More information about the ffmpeg-devel
mailing list