[FFmpeg-devel] [PATCH] libavfilter/avf_showcqt: Add check for av_calloc()

Jiasheng Jiang jiashengjiangcool at gmail.com
Thu Aug 7 05:34:23 EEST 2025


Add check for the return value of av_calloc() to avoid potential NULL pointer dereference.

Fixes: 0068b3d0f0 ("avfilter/avf_showcqt: switch to TX FFT from avutil")
Signed-off-by: Jiasheng Jiang <jiashengjiangcool at gmail.com>
---
 libavfilter/avf_showcqt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libavfilter/avf_showcqt.c b/libavfilter/avf_showcqt.c
index f6a867a0ce..e1fc1c0259 100644
--- a/libavfilter/avf_showcqt.c
+++ b/libavfilter/avf_showcqt.c
@@ -1383,7 +1383,7 @@ static int config_output(AVFilterLink *outlink)
     s->fft_input = av_calloc(FFALIGN(s->fft_len + 64, 256), sizeof(*s->fft_input));
     s->fft_result = av_calloc(FFALIGN(s->fft_len + 64, 256), sizeof(*s->fft_result));
     s->cqt_result = av_malloc_array(s->cqt_len, sizeof(*s->cqt_result));
-    if (!s->fft_ctx || !s->fft_data || !s->fft_result || !s->cqt_result)
+    if (!s->fft_ctx || !s->fft_data || !s->fft_input || !s->fft_result || !s->cqt_result)
         return AVERROR(ENOMEM);
 
     s->remaining_fill_max = s->fft_len / 2;
-- 
2.25.1



More information about the ffmpeg-devel mailing list