[FFmpeg-devel] [PATCH] libswscale/tests/colorspace: Add av_free() to avoid potential memory leak

[Nicolas George]

Jiasheng Jiang (HE12025-08-08):
> Add av_free() to avoid potential memory leak.

This is main(), return means exit, no leak possible.

This applies to most cases in tests, even not in main(): if something
fails, the test will most likely exit with failure almost immediately,
leaks are not an issue.

Also:

> Fixes: 3a74415d59 ("cosmetics, expand all tabs to four spaces.")

This does not seem right. I do not know what is adding these comments,
but its attribution logic seems a little simplistic. Just because¹ the
same lines were changes last in that patch does not mean that patch is
what introduced the issue. It is quite obvious in that case with a
cosmetic commit.

Regards,

-- 
  Nicolas George


1: Strange construction, but apparently idiomatic.