[FFmpeg-devel] [RFC] AAC (USAC) bug

[Michael Niedermayer]

Hi

On Fri, Aug 08, 2025 at 10:36:48AM -0300, James Almer wrote:
> On 8/8/2025 10:28 AM, Michael Niedermayer wrote:
> > Hi
> > 
> > AAC USAC conatains a double free since 6 month
> > (https://issues.oss-fuzz.com/issues/393523547)
> > 
> > A WIP fix is here:
> 
> WIP how? Is it incomplete?

Andreas said this:
"Unchecked allocation. Furthermore, the *dst = *src makes cleanup on
 error here a PITA. Would making pl_data reference-counted (via
 RefStruct) work instead?"

I hoped someone would implement the RefStruct stuff. I didnt anticipate
noone would even reply multiple pings


> 
> > https://lists.ffmpeg.org/pipermail/ffmpeg-devel/2025-February/339564.html
> > 
> > what do people prefer here to be done ?
> > should we delay the release until someone fixes this ?
> 
> If the above fix works, then it can be applied until a better one is done

It would be needed to make sure teh issue Andreas raised is dealt with
either with or without RefStruct.

when I asked in that thread if others wanted to work on this i wouldnt
at the same time start working on it (that would be duplicate work
potentially) and then i of course forgot as noone even said "No"


> (Lynne owns this code, so she should probably look at it).

that would be very good, yes

thx

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The day soldiers stop bringing you their problems is the day you have stopped 
leading them. They have either lost confidence that you can help or concluded 
you do not care. Either case is a failure of leadership. - Colin Powell
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20250808/0f00e430/attachment.sig>