[FFmpeg-devel] Pushing without approval avfilter/vf_vignette: use AVFilterContext for logging

[Niklas Haas]

On Tue, 12 Aug 2025 11:53:20 +0200 Nicolas George <george at nsup.org> wrote:
> Niklas Haas (HE12025-08-12):
> > I see that, but note:
> > 1) the PR *was* approved
>
> How do you know that approval was worth anything?

As far as my understanding goes, only people with write access to the
repository status have the ability to merge or approve PRs. If you do not
feel somebody can be trusted with write access, that is a separate issue
irrelevant to this discussion.

That aside, the person who reviewed the PR also has about 100x more activity
than you in the past 2-year period and is also a member of the GA. I think
it's fair to assume they are qualified to review a trivial patch.

> > 2) nobody is listed as a maintainer for these filters
>
> So as a default, they are maintained by whoever maintains libavfilter as
> a whole, which means me since Stefano took steps back from development.

Where in "MAINTAINERS" is this written?

> Technical solution will not solve human problems.

Having a clearly defined process is a human solution to a human problem.