[FFmpeg-devel] Pushing without approval avfilter/vf_vignette: use AVFilterContext for logging

[Kacper Michajlow]

On Tue, 12 Aug 2025 at 14:35, Tristan Matthews via ffmpeg-devel
<ffmpeg-devel at ffmpeg.org> wrote:
>
>
>
>
>
> Hi,
>
> On Tuesday, August 12th, 2025 at 5:51 AM, Niklas Haas <ffmpeg at haasn.xyz> wrote:
>
> > On Tue, 12 Aug 2025 15:08:10 +0530 Gyan Doshi ffmpeg at gyani.pro wrote:
> >
> > > On 2025-08-12 03:04 pm, Niklas Haas wrote:
> > >
> > > > On Tue, 12 Aug 2025 11:16:19 +0200 Nicolas George george at nsup.org wrote:
> > > >
> > > > > ffmpeg-git at ffmpeg.org (HE12025-08-12):
> > > > >
> > > > > > Author: Niklas Haas git at haasn.dev
> > > > > > AuthorDate: Mon Aug 11 15:57:24 2025 +0200
> > > > > > Commit: Niklas Haas ffmpeg at haasn.dev
> > > > > > CommitDate: Tue Aug 12 09:01:39 2025 +0000
> > > > > > Pushing after less than 24 hours without approval by the maintainer is
> > > > > > absolutely unacceptable, forge or no forge, and a spit in my face for
> > > > > > the time I invested into starting to look at the code, thankfully
> > > > > > limited.
> > > > > > In https://ffmpeg.org/developer.html#Patch-review-process it says:
> > > >
> > > > > After a patch is approved it will be committed to the repository.
> > > > > I don't see anything about a time-frame requirement here.
> > >
> > > It's the last point in
> > > https://ffmpeg.org/developer.html#Patches_002fCommitting
> >
> >
> > I see that, but note:
> > 1) the PR was approved
> > 2) nobody is listed as a maintainer for these filters
> >
> > Regardless, I still think we should then just establish a clear pipeline
> > here to prevent this sort of discussion from happening in the future.
> >
> > Timo, can something like the VLC merge bot be implemented in ForgeJo?
> >
>
> For reference, that's https://code.videolan.org/Garf/homer-bot
> Obviously that's gitlab specific but may help inform some choices here.

Because of course there is homer-bot... I think everyone seen
marge-bot too https://github.com/smarkets/marge-bot (also GitLab
specific)

Forgejo is API compatible with GitHub, so we could reuse solutions
that work there. Also in general Forgejo itself is more basic in
itself, doesn't support marge queues/trains, so any solution would
have to be a custom bot.

- Kacper