[FFmpeg-devel] [PATCH v2 3/3] avfilter/scale_cuda: Add support for 4:2:2 chroma subsampling

[Philip Langdale]

On Tue, 8 Jul 2025 11:19:45 +0000
Diego de Souza via ffmpeg-devel <ffmpeg-devel at ffmpeg.org> wrote:

> Hi Andreas,
> 
> Do you mean something like this?
> 
> struct format_entry {
>     enum AVPixelFormat format;
>     char name[16];
> };
> 
> static const struct format_entry supported_formats[] = {
>     {AV_PIX_FMT_YUV420P,  "planar8"},
>     {AV_PIX_FMT_YUV422P,  "planar8"},
>     {AV_PIX_FMT_YUV444P,  "planar8"},
>     {AV_PIX_FMT_YUV420P10,"planar10"},
>     {AV_PIX_FMT_YUV422P10,"planar10"},
>     {AV_PIX_FMT_YUV444P10,"planar10"},
>     {AV_PIX_FMT_YUV444P16,"planar16"},
>     {AV_PIX_FMT_NV12,     "semiplanar8"},
>     {AV_PIX_FMT_NV16,     "semiplanar8"},
>     {AV_PIX_FMT_P010,     "semiplanar10"},
>     {AV_PIX_FMT_P210,     "semiplanar10"},
>     {AV_PIX_FMT_P016,     "semiplanar16"},
>     {AV_PIX_FMT_P216,     "semiplanar16"},
>     {AV_PIX_FMT_0RGB32,   "bgr0"},
>     {AV_PIX_FMT_0BGR32,   "rgb0"},
>     {AV_PIX_FMT_RGB32,    "bgra"},
>     {AV_PIX_FMT_BGR32,    "rgba"},
> };
> 
> Best regards,
> 
> Diego de Souza
> Sr. Video Coding DevTech
> NVIDIA<http://www.nvidia.com/>
> On 07.07.25, 12:24, "ffmpeg-devel" <ffmpeg-devel-bounces at ffmpeg.org>
> wrote:
> 
> External email: Use caution opening links or attachments
> 
> 
> Diego Felix de Souza via ffmpeg-devel:
> > +struct format_entry {
> > +    enum AVPixelFormat format;
> > +    const char *name;
> > +};
> > +
> > +static const struct format_entry supported_formats[] = {
> > +    {AV_PIX_FMT_YUV420P,  "planar8"},
> > +    {AV_PIX_FMT_YUV422P,  "planar8"},
> > +    {AV_PIX_FMT_YUV444P,  "planar8"},
> > +    {AV_PIX_FMT_YUV420P10,"planar10"},
> > +    {AV_PIX_FMT_YUV422P10,"planar10"},
> > +    {AV_PIX_FMT_YUV444P10,"planar10"},
> > +    {AV_PIX_FMT_YUV444P16,"planar16"},
> > +    {AV_PIX_FMT_NV12,     "semiplanar8"},
> > +    {AV_PIX_FMT_NV16,     "semiplanar8"},
> > +    {AV_PIX_FMT_P010,     "semiplanar10"},
> > +    {AV_PIX_FMT_P210,     "semiplanar10"},
> > +    {AV_PIX_FMT_P016,     "semiplanar16"},
> > +    {AV_PIX_FMT_P216,     "semiplanar16"},
> > +    {AV_PIX_FMT_0RGB32,   "bgr0"},
> > +    {AV_PIX_FMT_0BGR32,   "rgb0"},
> > +    {AV_PIX_FMT_RGB32,    "bgra"},
> > +    {AV_PIX_FMT_BGR32,    "rgba"},
> >  };  
> 
> Please avoid reloactions here.

Hi Andreas,

I'm trying to go through these patches, and I don't understand what you
were asking for Diego to change here. The original format list is
replaced, but that's because it's turned into a list of structs from a
list of constants. Or were you referring to something else. I also
can't see what is different about Diego's proposed alternative.

I want to make sure whatever change you're asking for is eventually
included.

Thanks,

--phil