[FFmpeg-devel] [PATCH] avformat/matroskaenc: log unsupported subtitle codec name

[Andreas Rheinhardt]

Zhao Zhili:
> From: Zhao Zhili <zhilizhao at tencent.com>
> 
> It's more user friendly than codec ID.
> ---
>  libavformat/matroskaenc.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/libavformat/matroskaenc.c b/libavformat/matroskaenc.c
> index 3285735a7f..2e06f68304 100644
> --- a/libavformat/matroskaenc.c
> +++ b/libavformat/matroskaenc.c
> @@ -2084,7 +2084,8 @@ static int mkv_write_track(AVFormatContext *s, MatroskaMuxContext *mkv,
>  
>      case AVMEDIA_TYPE_SUBTITLE:
>          if (!native_id) {
> -            av_log(s, AV_LOG_ERROR, "Subtitle codec %d is not supported.\n", par->codec_id);
> +            av_log(s, AV_LOG_ERROR, "Subtitle codec %s (%d) is not supported.\n",
> +                    avcodec_get_name(par->codec_id), par->codec_id);
>              return AVERROR(ENOSYS);
>          }
>          if (!IS_WEBM(mkv) && st->disposition & AV_DISPOSITION_DESCRIPTIONS)

LGTM

- Andreas