[FFmpeg-devel] [PATCH] avutil/frame.h: improve documentation for AV_FRAME_FLAG_LOSSLESS

[Alexander Strasser]

On 2025-01-07 20:13 -0500, Leo Izen wrote:
> It should be more clear what this flag is indicating with a more
> verbose comment documenting it.
>
> Signed-off-by: Leo Izen <leo.izen at gmail.com>
> ---
>  libavutil/frame.h | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/libavutil/frame.h b/libavutil/frame.h
> index 993fa6b65a..e3657f193f 100644
> --- a/libavutil/frame.h
> +++ b/libavutil/frame.h
> @@ -666,7 +666,13 @@ typedef struct AVFrame {
>   */
>  #define AV_FRAME_FLAG_TOP_FIELD_FIRST (1 << 4)
>  /**
> - * A flag to mark frames which were encoded losslessly from the input.
> + * A flag to mark frames that a decoder has determined were originally encoded
> + * losslessly.
> + *
> + * For coding bitstream formats which support both lossless and lossy
> + * encoding, it is sometimes possible for a decoder to determine which method
> + * was used when the bitsream was encoded.

> Frames marked with this flag
> + * have been identified by a decoder as having been losslessly encoded, originally.

Personally I would drop this last sentence.
It's a bit verbose and adds nothing new AFAICT.

>   */
>  #define AV_FRAME_FLAG_LOSSLESS        (1 << 5)
>  /**
> --

LGTM maybe Marton can also comment.


Thanks,
  Alexander