[FFmpeg-devel] [PATCH v2] fate/vvc: Add vvc-frames-with-ltr.vvc

James Almer jamrial at gmail.com
Wed Jan 8 15:11:01 EET 2025


On 1/8/2025 8:49 AM, Frank Plowman wrote:
> This sample is rather difficult, containing a lot of subtle edge cases
> which revealed errors in the VVC decoder.  It covers 88.4% of lines in
> libavcodec/vvc and brings the line coverage of the entire VVC fate suite
> from 96.3% to 97.2%.
> 
> Signed-off-by: Frank Plowman <post at frankplowman.com>
> ---
> Changes since v1:
> * Remove instantiation of empty $(SCALE_OPTS) in
>    fate-vvc-frames-with-ltr.
> * Move fate-vvc-frames-with-ltr to collection of VVC test cases which
>    require libswscale as it is a 10-bit sequence.
> ---
>   tests/fate/vvc.mak                 |  8 +++++---
>   tests/ref/fate/vvc-frames-with-ltr | 25 +++++++++++++++++++++++++
>   2 files changed, 30 insertions(+), 3 deletions(-)
>   create mode 100644 tests/ref/fate/vvc-frames-with-ltr
> 
> diff --git a/tests/fate/vvc.mak b/tests/fate/vvc.mak
> index fb176b7745..76a4255e27 100644
> --- a/tests/fate/vvc.mak
> +++ b/tests/fate/vvc.mak
> @@ -43,11 +43,13 @@ $(VVC_TESTS_10BIT): SCALE_OPTS := -pix_fmt yuv420p10le -vf scale
>   $(VVC_TESTS_444_10BIT): SCALE_OPTS := -pix_fmt yuv444p10le -vf scale
>   fate-vvc-conformance-%: CMD = framecrc -c:v vvc -i $(TARGET_SAMPLES)/vvc-conformance/$(subst fate-vvc-conformance-,,$(@)).bit $(SCALE_OPTS)
>   fate-vvc-output-ref: CMD = framecrc -c:v vvc -i $(TARGET_SAMPLES)/vvc/Hierarchical.bit $(SCALE_OPTS)
> +fate-vvc-frames-with-ltr: CMD = framecrc -c:v vvc -i $(TARGET_SAMPLES)/vvc/vvc_frames_with_ltr.vvc

SCALE_OPTS may have been an empty string if used here, but "-pix_fmt 
yuv420p10le -vf scale" is still needed. Otherwise the test will fail on 
BE systems.

I amended the patch and pushed it. Thanks.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature.asc
Type: application/pgp-signature
Size: 495 bytes
Desc: OpenPGP digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20250108/eb95b69e/attachment.sig>


More information about the ffmpeg-devel mailing list