[FFmpeg-devel] [PATCH 1/5] avcodec/ffv1enc: Fix handling of 32bit unsigned sambols

[Michael Niedermayer]

Hi Alexander

On Sun, Jan 12, 2025 at 01:37:05PM +0100, Alexander Strasser via ffmpeg-devel wrote:
> On 2025-01-10 05:06 +0100, Michael Niedermayer wrote:
> > This may be needed for floats
> >
> > Sponsored-by: Sovereign Tech Fund
> > Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
> > ---
> >  libavcodec/ffv1enc.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/libavcodec/ffv1enc.c b/libavcodec/ffv1enc.c
> > index 1a0413895a1..e2db1b41640 100644
> > --- a/libavcodec/ffv1enc.c
> > +++ b/libavcodec/ffv1enc.c
> > @@ -199,7 +199,7 @@ static av_always_inline av_flatten void put_symbol_inline(RangeCoder *c,
> >      } while (0)
> >
> >      if (v) {
> > -        const int a = FFABS(v);
> > +        const unsigned a = is_signed ? FFABS(v) : v;
> >          const int e = av_log2(a);
> >          put_rac(c, state + 0, 0);
> >          if (e <= 9) {
> > --
> 
> LGTM but s/sambols/symbols/ in the Subject/Git-short-message I suspect.

will apply with symbols

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Into a blind darkness they enter who follow after the Ignorance,
they as if into a greater darkness enter who devote themselves
to the Knowledge alone. -- Isha Upanishad
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20250113/aae4cbc2/attachment.sig>