[FFmpeg-devel] [PATCH 2/6] avformat/whip: reindent whip options
Jack Lau
jacklau1222gm at gmail.com
Wed Jul 2 15:03:32 EEST 2025
> On Jul 2, 2025, at 13:10, Steven Liu <lingjiujianke-at-gmail.com at ffmpeg.org> wrote:
>
> Jack Lau <jacklau1222gm-at-gmail.com at ffmpeg.org> 于2025年7月2日周三 12:25写道:
>>
>> Signed-off-by: Jack Lau <jacklau1222 at qq.com>
>> ---
>> libavformat/whip.c | 21 ++++++++++++++-------
>> 1 file changed, 14 insertions(+), 7 deletions(-)
>>
>> diff --git a/libavformat/whip.c b/libavformat/whip.c
>> index be6ee9c951..8d1be90f32 100644
>> --- a/libavformat/whip.c
>> +++ b/libavformat/whip.c
>> @@ -1904,13 +1904,20 @@ static int whip_check_bitstream(AVFormatContext *s, AVStream *st, const AVPacket
>> #define OFFSET(x) offsetof(WHIPContext, x)
>> #define ENC AV_OPT_FLAG_ENCODING_PARAM
>> static const AVOption options[] = {
>> - { "handshake_timeout", "Timeout in milliseconds for ICE and DTLS handshake.", OFFSET(handshake_timeout), AV_OPT_TYPE_INT, { .i64 = 5000 }, -1, INT_MAX, ENC },
>> - { "pkt_size", "The maximum size, in bytes, of RTP packets that send out", OFFSET(pkt_size), AV_OPT_TYPE_INT, { .i64 = 1200 }, -1, INT_MAX, ENC },
>> - { "authorization", "The optional Bearer token for WHIP Authorization", OFFSET(authorization), AV_OPT_TYPE_STRING, { .str = NULL }, 0, 0, ENC },
>> - { "cert_file", "The optional certificate file path for DTLS", OFFSET(cert_file), AV_OPT_TYPE_STRING, { .str = NULL }, 0, 0, ENC },
>> - { "key_file", "The optional private key file path for DTLS", OFFSET(key_file), AV_OPT_TYPE_STRING, { .str = NULL }, 0, 0, ENC },
>> - { "whip_flags", "Set flags affecting WHIP connection behavior", OFFSET(flags), AV_OPT_TYPE_FLAGS, { .i64 = 0 }, 0, UINT_MAX, ENC, .unit = "flags" },
>> - { "ignore_ipv6", "(Optional) Ignore any IPv6 ICE candidate", 0, AV_OPT_TYPE_CONST, { .i64 = WHIP_FLAG_IGNORE_IPV6 }, 0, UINT_MAX, ENC, .unit = "flags" },
>> + { "handshake_timeout", "Timeout in milliseconds for ICE and DTLS handshake.", OFFSET(handshake_timeout),
>> + AV_OPT_TYPE_INT, { .i64 = 5000 }, -1, INT_MAX, ENC },
>> + { "pkt_size", "The maximum size, in bytes, of RTP packets that send out", OFFSET(pkt_size),
>> + AV_OPT_TYPE_INT, { .i64 = 1200 }, -1, INT_MAX, ENC },
>> + { "authorization", "The optional Bearer token for WHIP Authorization", OFFSET(authorization),
>> + AV_OPT_TYPE_STRING, { .str = NULL }, 0, 0, ENC },
>> + { "cert_file", "The optional certificate file path for DTLS", OFFSET(cert_file),
>> + AV_OPT_TYPE_STRING, { .str = NULL }, 0, 0, ENC },
>> + { "key_file", "The optional private key file path for DTLS", OFFSET(key_file),
>> + AV_OPT_TYPE_STRING, { .str = NULL }, 0, 0, ENC },
>> + { "whip_flags", "Set flags affecting WHIP connection behavior", OFFSET(flags),
>> + AV_OPT_TYPE_FLAGS, { .i64 = 0 }, 0, UINT_MAX, ENC, .unit = "flags" },
>> + { "ignore_ipv6", "(Optional) Ignore any IPv6 ICE candidate", 0,
>> + AV_OPT_TYPE_CONST, { .i64 = WHIP_FLAG_IGNORE_IPV6 }, 0, UINT_MAX, ENC, .unit = "flags" },
>> { NULL },
>> };
>>
>> --
>> 2.49.0
>>
>> _______________________________________________
>> ffmpeg-devel mailing list
>> ffmpeg-devel at ffmpeg.org
>> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>>
>> To unsubscribe, visit link above, or email
>> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".
> Why does every option break into two new lines?
>
Already submitted the v2 patchset
https://ffmpeg.org/pipermail/ffmpeg-devel/2025-July/346072.html
> Thanks
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe”.
Thanks
Jack
More information about the ffmpeg-devel
mailing list