[FFmpeg-devel] [PATCH 2/2] avcodec/sanm: avoid using k in left pxoff check

[Manuel Lauss]

Servus Michael,

On Sat, May 31, 2025 at 12:51 AM Michael Niedermayer
<michael at niedermayer.cc> wrote:

> > > >              /* smooth top and left block borders with neighbours */
> > > > -            if (((pxoff - p + k) < 0) || ((pxoff - p + k) >= maxpxo)
> > > > +            if (((pxoff - p + 0) < 0) || ((pxoff - p + k) >= maxpxo)
> > > >                  || ((pxoff + 3 * p) < 0) || ((pxoff + 3 * p) >= maxpxo)
> > > >                  || (i == 0) || (j == 0))
> > > >                  continue;
> >
> > Oops, yes, that change is correct.
>
> will apply
>
>
> > I think you should just rip the whole block-smoothing block out
> > entirely: it creates a "sawtooth" pattern
> > which is more annoying than the "blockiness" it tries to soften.
>
> probably, but i just wanted to fix the out of array access,
> ill leave improvment beyond that to others

Is it OK if I just remove this block entirely?  I'd commit that along
with the other 2 sanm patches I have.

Manuel