[FFmpeg-devel] [PATCH WIP 01/10] ffbuild/bin2c: Use zlib directly instead of gzip

[softworkz .]

> -----Original Message-----
> From: ffmpeg-devel <ffmpeg-devel-bounces at ffmpeg.org> On Behalf Of Andreas
> Rheinhardt
> Sent: Dienstag, 3. Juni 2025 16:34
> To: ffmpeg-devel at ffmpeg.org
> Subject: Re: [FFmpeg-devel] [PATCH WIP 01/10] ffbuild/bin2c: Use zlib directly
> instead of gzip
> 
> softworkz .:
> >
> >
> >> -----Original Message-----
> >> From: ffmpeg-devel <ffmpeg-devel-bounces at ffmpeg.org> On Behalf Of Andreas
> >> Rheinhardt
> >> Sent: Montag, 2. Juni 2025 04:39
> >> To: FFmpeg development discussions and patches <ffmpeg-devel at ffmpeg.org>
> >> Subject: [FFmpeg-devel] [PATCH WIP 01/10] ffbuild/bin2c: Use zlib directly
> >> instead of gzip
> >>
> >> This is a WIP patchset to further improve the resource manager. The
> >> configure bits are the one that need more work: How do we detect zlib
> >> (and the required library to link to) on the host system?
> >>
> >
> > Hi,
> >
> > I ran CI builds for the whole Patchset
> > https://github.com/ffstaging/FFmpeg/pull/91
> >
> >
> > Mac build fails (all others are fine)
> >
> https://dev.azure.com/githubsync/ffmpeg/_build/results?buildId=91751&view=logs
> >
> >
> >
> > Undefined symbols for architecture x86_64:
> > Undefined symbols for architecture x86_64:
> >   "_ff_vf_yadif_videotoolbox_metallib_len", referenced from:
> >       _do_init in libavfilter.a[397](vf_yadif_videotoolbox.o)
> > ld: symbol(s) not found for architecture x86_64
> > clang: error: linker command failed with exit code 1 (use -v to see
> invocation)
> > make: *** [ffprobe_g] Error 1
> >   "_ff_vf_yadif_videotoolbox_metallib_len", referenced from:
> >       _do_init in libavfilter.a[397](vf_yadif_videotoolbox.o)
> > ld: symbol(s) not found for architecture x86_64
> > clang: error: linker command failed with exit code 1 (use -v to see
> invocation)
> > make: *** [ffplay_g] Error 1
> >
> 
> Thanks for the test. I overlooked that this was also used by metal.
> Updated version attached and also available at
> https://github.com/mkver/FFmpeg/tree/bin2c.

Thanks, I re-pushed and PRed it here:
https://github.com/ffstaging/FFmpeg/pull/92
(will take up to 1h until all builds are through)


> Btw: The non-bin2c patches
> are actually logically independent from the bin2c patches and don't need
> to wait for them (there will be rebase conflicts when changing the
> order, but fixing them would be on me).

From my side, there's no urgency in this,
it can wait until you got it all together.


> The metal bits are untested, but should work.

I don't have a mac, so I can't test locally. Not sure whether FATE is 
including some metal tests? Then I could try enabling HW tests on
the builder..


> I have not worked on the configure bits.

I'm totally clueless in that area, unfortunately 😊

Best
sw