[FFmpeg-devel] [PATCH] swscale/aarch64/output: Implement neon assembly for yuv2nv12cX_c()

[Martin Storsjö]

On Fri, 6 Jun 2025, Harshitha Sarangu Suresh wrote:

> Changed indentation, checked for FATE tests and gha-aarch64 git 
> workflow. Everything passed.

I doubt that everything passed; this doesn't even compile. See below:

> @@ -275,7 +291,10 @@ av_cold void ff_sws_init_swscale_aarch64(SwsInternal *c)
>         ASSIGN_VSCALE_FUNC(c->yuv2plane1, neon);
>         if (c->dstBpc == 8) {
>             c->yuv2planeX = ff_yuv2planeX_8_neon;
> +            if(isSemiPlanarYUV(c->opts.dst_format)
> +               ASSIGN_YUV2NV12_FUNC(c->yuv2nv12cX, neon, c->opts.dst_format);
>         }
> +

src/libswscale/aarch64/swscale.c: In function 
‘ff_sws_init_swscale_aarch64’:
src/libswscale/aarch64/swscale.c:294:51: error: expected ‘)’ before ‘if’
   294 |             if(isSemiPlanarYUV(c->opts.dst_format)
       |               ~                                   ^
       |                                                   )

// Martin