[FFmpeg-devel] [PATCH] avformat/tls_openssl: fix warnings when openssl is lower version

[Steven Liu]

Jack Lau via ffmpeg-devel <ffmpeg-devel at ffmpeg.org> 于2025年6月7日周六 09:35写道：
>
> In higher versions (like openssl 1.1.1 and higher),
> the function signature is BIO *BIO_new_mem_buf(const void *buf, int len),
> so passing a const string doesn't cause an warnings.
> However, in lower versions of OpenSSL,
> the function signature becomes BIO *BIO_new_mem_buf(void *buf, int len),
> which leads to warnings.
>
> OpenSSL guarantees that it will not modify the string,
> so it's safe to cast the pem_str to (void *) to avoid this warning.
>
> Signed-off-by: Jack Lau <jacklau1222 at qq.com>
> ---
>  libavformat/tls_openssl.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/libavformat/tls_openssl.c b/libavformat/tls_openssl.c
> index 86e8935fee..5387e21df1 100644
> --- a/libavformat/tls_openssl.c
> +++ b/libavformat/tls_openssl.c
> @@ -415,7 +415,7 @@ error:
>   */
>  static EVP_PKEY *pkey_from_pem_string(const char *pem_str, int is_priv)
>  {
> -    BIO *mem = BIO_new_mem_buf(pem_str, -1);
> +    BIO *mem = BIO_new_mem_buf((void *)pem_str, -1);
>      if (!mem) {
>          av_log(NULL, AV_LOG_ERROR, "BIO_new_mem_buf failed\n");
>          return NULL;
> @@ -445,7 +445,7 @@ static EVP_PKEY *pkey_from_pem_string(const char *pem_str, int is_priv)
>   */
>  static X509 *cert_from_pem_string(const char *pem_str)
>  {
> -    BIO *mem = BIO_new_mem_buf(pem_str, -1);
> +    BIO *mem = BIO_new_mem_buf((void *)pem_str, -1);
>      if (!mem) {
>          av_log(NULL, AV_LOG_ERROR, "BIO_new_mem_buf failed\n");
>          return NULL;
> --
> 2.49.0
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".

LGTM


Thanks
Steven