[FFmpeg-devel] [PATCH 1/2] Replace FFMIN/FFMAX by type specific macros
Andreas Rheinhardt
andreas.rheinhardt at outlook.com
Sun Jun 8 23:47:59 EEST 2025
Michael Niedermayer:
> On Sun, Jun 08, 2025 at 01:37:32AM +0200, Andreas Rheinhardt wrote:
>> Michael Niedermayer:
>>> Hi
>>>
>>> On Wed, Jun 04, 2025 at 03:05:12AM +0200, Michael Niedermayer wrote:
>>> [...]
>>>>>> #define FFSWAP(type,a,b) do{type SWAP_tmp= b; b= a; a= SWAP_tmp;}while(0)
>>>>>
>>>>> 1. I don't like that you change the common case (namely the integer one)
>>>>> and thereby making the name longer (and making this patch huge).
>>>>
>>>> I can just rename FFMINI/MAXI to FFMIN/MAX if preferred
>>>
>>> are there any objections to FFMIND / FFMINF / FFMAXD / FFMAXF ?
>>> if not i intend to apply these in the next days (unless i forget)
>>>
>>
>> I don't want them to be public.
>
> in which header file do you want them ?
>
lavu/internal.h seems to be the least bad option.
- Andreas
More information about the ffmpeg-devel
mailing list