[FFmpeg-devel] [PATCH 4/4] fftools/textformat: remove useless error check

Andreas Rheinhardt andreas.rheinhardt at outlook.com
Wed Jun 11 23:53:09 EEST 2025


Marvin Scholz:
> This can never be reached as the errors are already handled
> locally when they occur in the code preceding this.
> ---
>  fftools/textformat/avtextformat.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/fftools/textformat/avtextformat.c b/fftools/textformat/avtextformat.c
> index e1aaa9ba57..6a309f040b 100644
> --- a/fftools/textformat/avtextformat.c
> +++ b/fftools/textformat/avtextformat.c
> @@ -229,8 +229,6 @@ int avtext_context_open(AVTextFormatContext **ptctx, const AVTextFormatter *form
>  
>      if (tctx->formatter->init)
>          ret = tctx->formatter->init(tctx);
> -    if (ret < 0)
> -        goto fail;
>  
>      *ptctx = tctx;
>  

And when init fails?

- Andreas



More information about the ffmpeg-devel mailing list