[FFmpeg-devel] [PATCH v2] ogg/vorbis: implement header packet skip in chained ogg bitstreams.

[Romain Beauxis]

Le jeu. 12 juin 2025 à 13:35, Michael Niedermayer <michael at niedermayer.cc>
a écrit :
>
> Hi Romain

Hi,

> On Tue, Jun 10, 2025 at 01:04:35PM -0500, Romain Beauxis wrote:
> > Hi all,
> >
> >
> > Le mer. 4 juin 2025 à 11:58, Romain Beauxis <romain.beauxis at gmail.com>
a écrit :
> > >
> > > This is a redo of 574f634e49847e2225ee50013afebf0de03ef013 using a
flat
> > > memory storage for the extradata.
> > >
> > > PR review comments addressed:
> > > * Use flat memory bytestream
> > > * Re-use existing xiph extradata layout
> >
> > Is there any interest in reviewing this patch?
>
> maybe you can help review other peoples patches while you wait for someone
> to review yours (if everyone does that then reviews should overall occur
> quicker)
> (i do have a backlog of things atm so i dont think i should add this one
>  to my todo)

I do appreciate the invite to contribute to reviews and will gladly do so.

I understand how the project needs to balance load and how it's nice to
contribute both ways.

However, I'm still learning the ropes of this code base (and this patch
proves it).

It seems awkward to make this transactional, there's a discrepancy in what
I can provide in terms of senior review and this patch is rather small and
implements exactly what I was asked to do after multiple consultations.

I was hoping it would be easy to review and merge.

Thanks,
-- Romain