[FFmpeg-devel] [PATCH 2/3] avcodec/osq: Add note about update_stats() count

[Michael Niedermayer]

It seems this is basically unused and unfinished code

Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
---
 libavcodec/osq.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/libavcodec/osq.c b/libavcodec/osq.c
index 14c723ed9c6..d3b1d86ee35 100644
--- a/libavcodec/osq.c
+++ b/libavcodec/osq.c
@@ -150,6 +150,8 @@ static void update_stats(OSQChannel *cb, int val)
     cb->history[cb->pos] = FFABS((int64_t)val);
     cb->pos++;
     cb->count++;
+    //NOTE for this to make sense count would need to be limited to FF_ARRAY_ELEMS(cb->history)
+    //Otherwise the average computation later makes no sense
     if (cb->pos >= FF_ARRAY_ELEMS(cb->history))
         cb->pos = 0;
 }
-- 
2.49.0