[FFmpeg-devel] [PATCH v3] avcodec/h264: fixed qp table attach for h264

[Timothee]

Context from the first version :

> Here is a patch where I fixed the attach of per-macroblock qp tables for
> H.264. It was implemented for MPEG2 so I have only extended it.
>
> I tested the functionality with the codecview filter using the following
> command: `./ffmpeg -export_side_data 4 -i input.mp4 -vf codecview=qp=1
> output.mp4`

Andreas :
> 1. Commits should be small atomic units; changes to different libraries
> in the same commit are almost always not of this type.
> 2. Both ff_h264_decode_mb_cabac() and ff_h264_decode_mb_cavlc() already
> set qscale_table on their own (on success), so that all the changes to
> h264_slice.c seem completely redundant.
>
> - Andreas

Here is a new version of the patch without the redundant lines.

Thanks,

Timothée
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-avcodec-h264-fixed-qp-table-attach-for-h264.patch
Type: text/x-patch
Size: 1461 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20250617/a29b334b/attachment.bin>