[FFmpeg-devel] [PATCH 2/4] avfilter/asrc_sinc: fix leak in config_input()

[Michael Niedermayer]

Hi

On Mon, Jun 23, 2025 at 08:48:05PM +0800, ld y wrote:
> Michael Niedermayer <michael at niedermayer.cc> writes：
> 
> > does the other return in config_output() not need this free too?
> >
> 
> I believe all the other return behind fir_to_phase() has called
> av_free(h[longer])
> already. I would love to add this message to my next patch series.

doesnt the failure path here need the free too ?
        int ret = fir_to_phase(s, &h[longer], &n, &post_peak, s->phase);
        if (ret < 0)
            return ret;

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Homeopathy is like voting while filling the ballot out with transparent ink.
Sometimes the outcome one wanted occurs. Rarely its worse than filling out
a ballot properly.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20250624/88101ca9/attachment.sig>