[FFmpeg-devel] [PATCH 2/4] avcodec/vorbisenc: fix leak if av_mallocz failed
Lidong Yan
yldhome2d2 at gmail.com
Fri Jun 27 17:09:16 EEST 2025
In put_main_header(), av_mallocz() allocates memory to local variable
buffer, buffer leaks if av_mallocz() to *out failed. Add av_free(buffer)
before return error code.
Signed-off-by: Lidong Yan <502024330056 at smail.nju.edu.cn>
---
libavcodec/vorbisenc.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/libavcodec/vorbisenc.c b/libavcodec/vorbisenc.c
index 99ac72c910..b4680a11ed 100644
--- a/libavcodec/vorbisenc.c
+++ b/libavcodec/vorbisenc.c
@@ -740,8 +740,10 @@ static int put_main_header(vorbis_enc_context *venc, uint8_t **out)
len = hlens[0] + hlens[1] + hlens[2];
p = *out = av_mallocz(64 + len + len/255);
- if (!p)
+ if (!p) {
+ av_freep(&buffer);
return AVERROR(ENOMEM);
+ }
*p++ = 2;
p += av_xiphlacing(p, hlens[0]);
--
2.50.0.108.g6ae0c543ae
More information about the ffmpeg-devel
mailing list