[FFmpeg-devel] [PATCH] avcodec/mpeg12dec: Use proper logcontext

[Ramiro Polla]

On 3/4/25 23:11, Andreas Rheinhardt wrote:
> Patch attached

> diff --git a/libavcodec/mpeg12dec.c b/libavcodec/mpeg12dec.c
> index 843640edbf..14c028379e 100644
> --- a/libavcodec/mpeg12dec.c
> +++ b/libavcodec/mpeg12dec.c
> @@ -1655,11 +1655,11 @@ static int mpeg_decode_slice(MpegEncContext *s, int mb_y,
>      }
>  eos: // end of slice
>      if (get_bits_left(&s->gb) < 0) {
> -        av_log(s, AV_LOG_ERROR, "overread %d\n", -get_bits_left(&s->gb));
> +        av_log(s->avctx, AV_LOG_ERROR, "overread %d\n", -get_bits_left(&s->gb));
>          return AVERROR_INVALIDDATA;
>      }
>      *buf += (get_bits_count(&s->gb) - 1) / 8;
> -    ff_dlog(s, "Slice start:%d %d  end:%d %d\n", s->resync_mb_x, s->resync_mb_y, s->mb_x, s->mb_y);
> +    ff_dlog(s->avctx, "Slice start:%d %d  end:%d %d\n", s->resync_mb_x, s->resync_mb_y, s->mb_x, s->mb_y);
>      return 0;
>  }

LGTM.

We could also simplify mpeg_decode_slice() a bit more by using the local 
variables avctx, lowres, and field_pic (which have already been obtained 
from s).

Ramiro