[FFmpeg-devel] [PATCH v5 1/8] fftools/textformat: Extract and generalize textformat api from ffprobe.c

[Stefano Sabatini]

On date Saturday 2025-03-08 17:55:28 +0000, softworkz wrote:
> From: softworkz <softworkz at hotmail.com>
> 
> Signed-off-by: softworkz <softworkz at hotmail.com>
> ---
>  fftools/textformat/avtextformat.c  | 672 +++++++++++++++++++++++++++++
>  fftools/textformat/avtextformat.h  | 171 ++++++++
>  fftools/textformat/avtextwriters.h |  68 +++
>  fftools/textformat/tf_compact.c    | 282 ++++++++++++
>  fftools/textformat/tf_default.c    | 145 +++++++
>  fftools/textformat/tf_flat.c       | 174 ++++++++
>  fftools/textformat/tf_ini.c        | 160 +++++++
>  fftools/textformat/tf_json.c       | 215 +++++++++
>  fftools/textformat/tf_xml.c        | 221 ++++++++++
>  fftools/textformat/tw_avio.c       | 129 ++++++
>  fftools/textformat/tw_buffer.c     |  92 ++++
>  fftools/textformat/tw_stdout.c     |  82 ++++
>  12 files changed, 2411 insertions(+)
>  create mode 100644 fftools/textformat/avtextformat.c
>  create mode 100644 fftools/textformat/avtextformat.h
>  create mode 100644 fftools/textformat/avtextwriters.h
>  create mode 100644 fftools/textformat/tf_compact.c
>  create mode 100644 fftools/textformat/tf_default.c
>  create mode 100644 fftools/textformat/tf_flat.c
>  create mode 100644 fftools/textformat/tf_ini.c
>  create mode 100644 fftools/textformat/tf_json.c
>  create mode 100644 fftools/textformat/tf_xml.c
>  create mode 100644 fftools/textformat/tw_avio.c
>  create mode 100644 fftools/textformat/tw_buffer.c
>  create mode 100644 fftools/textformat/tw_stdout.c

Looks good to me.

As I said, there are a few API tweaks we might want to apply to
improve overall consistency and usability, but it is not blocking from
my side given this is internal API.