[FFmpeg-devel] [PATCH 01/21] avutil/avassert: Add av_unreachable and av_assume() macros

softworkz . softworkz at hotmail.com
Wed May 7 20:57:18 EEST 2025



> -----Original Message-----
> From: ffmpeg-devel <ffmpeg-devel-bounces at ffmpeg.org> On Behalf Of Andreas
> Rheinhardt
> Sent: Mittwoch, 7. Mai 2025 13:59
> To: FFmpeg development discussions and patches <ffmpeg-devel at ffmpeg.org>
> Subject: [FFmpeg-devel] [PATCH 01/21] avutil/avassert: Add av_unreachable and
> av_assume() macros
> 
> Patches attached.
> 
> - Andreas

Hi Andreas,

from https://ffmpeg.org/developer.html#Submitting-patches-1 

"..ensure the correct mime type is used (text/x-diff or text/x-patch or at least text/plain) and that only one patch is inline or attached per mail."

I'm saying that because the way you are submitting, Patchwork only ever recognizes the first attached patch, so - in this case - the remaining 20 patches are not checked by the CI runs.
It's also difficult to review patches that are submitted in this way, even more difficult to respond, as that requires to copy the patch into a text editor first, in order to add some synthetic quote marks ("> ") and when replying, it isn't clear to which of the patches the reply is corresponding to.

As long as there's no migration to a better way, why not try out making PRs to https://github.com/ffstaging/FFmpeg? 
AFAIC, I'm quite happy with that route, it's totally painless (no SMTP trouble, no manual sending).

Best regards,
sw 





More information about the ffmpeg-devel mailing list