[FFmpeg-devel] [PATCH v3] lavf: vvc_probe: enforce SPS -> PPS -> IRAP detection order to fix invalid stream detection

[Michael Niedermayer]

On Mon, May 12, 2025 at 07:36:35AM +0800, xiongweixiao wrote:
> The current vvc_probe function checks for SPS, PPS, and IRAP NAL units but does not enforce their detection order. This can lead to false positives when PPS or IRAP appear before SPS, causing malformed or non-compliant bitstreams to be incorrectly identified as valid VVC streams.
> 
> This patch modifies the logic to use boolean flags and enforces the correct detection sequence: SPS must be detected before PPS, and PPS before IRAP. This ensures more accurate probing and prevents invalid bitstreams from being misidentified.
> 
> This change addresses issues reported in:
> - https://trac.ffmpeg.org/ticket/11496
> - https://trac.ffmpeg.org/ticket/11087
> 
> Signed-off-by: xiongweixiao <xiongweixiaoxxw at gmail.com>
> 
> [v2] lavf: vvc_probe: fix based on review feedback
> 
> Changes since v1:
> - Added a flag to force sps, pps, iraq to appear in order;
> - Modified score where pps, iraq appeared in the wrong position;
> - Set a smaller score for incomplete sps, pps, iraq to deal with situations that may look like vvc format
> 
> Signed-off-by: xiongweixiao <xiongweixiaoxxw at gmail.com>
> 
> [v3] lavf fix code format
> remove trailing whitspace
> ---
>  libavformat/vvcdec.c | 19 ++++++++++++++++---
>  1 file changed, 16 insertions(+), 3 deletions(-)

will apply patch with updated commit message

thx

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The smallest minority on earth is the individual. Those who deny 
individual rights cannot claim to be defenders of minorities. - Ayn Rand
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20250512/58119737/attachment.sig>