[FFmpeg-devel] [PATCH 42/42] tests/fate/hevc: add a test for switching between single and multi-view

[softworkz .]

> -----Original Message-----
> From: ffmpeg-devel <ffmpeg-devel-bounces at ffmpeg.org> On Behalf Of Zhao Zhili
> Sent: Samstag, 30. November 2024 19:07
> To: FFmpeg development discussions and patches <ffmpeg-devel at ffmpeg.org>
> Subject: Re: [FFmpeg-devel] [PATCH 42/42] tests/fate/hevc: add a test for
> switching between single and multi-view
> 
> 
> > 在 2024年12月1日，上午1:22，James Almer <jamrial at gmail.com> 写道：
> >
> > On 11/30/2024 2:19 PM, Zhao Zhili wrote:
> >>> -----Original Message-----
> >>> From: ffmpeg-devel <ffmpeg-devel-bounces at ffmpeg.org> On Behalf Of James
> Almer
> >>> Sent: 2024年12月1日 0:51
> >>> To: ffmpeg-devel at ffmpeg.org
> >>> Subject: Re: [FFmpeg-devel] [PATCH 42/42] tests/fate/hevc: add a test for
> switching between single and multi-view
> >>>
> >>>> On 11/30/2024 1:38 PM, Zhao Zhili wrote:
> >>>>>
> >>>>>> -----Original Message-----
> >>>>>> From: ffmpeg-devel <ffmpeg-devel-bounces at ffmpeg.org> On Behalf Of Anton
> Khirnov
> >>>>>> Sent: 2024年8月27日 23:05
> >>>>>> To: ffmpeg-devel at ffmpeg.org
> >>>>>> Subject: [FFmpeg-devel] [PATCH 42/42] tests/fate/hevc: add a test for
> switching between single and multi-view
> >>>>>>
> >>>>>> ---
> >>>>>>   tests/fate/hevc.mak           |  10 ++
> >>>>>>   tests/ref/fate/hevc-mv-switch | 172
> ++++++++++++++++++++++++++++++++++
> >>>>>>   2 files changed, 182 insertions(+)
> >>>>>>   create mode 100644 tests/ref/fate/hevc-mv-switch
> >>>>>>
> >>>>>> diff --git a/tests/fate/hevc.mak b/tests/fate/hevc.mak
> >>>>>> index e75fbd3c16..5631ded860 100644
> >>>>>> --- a/tests/fate/hevc.mak
> >>>>>> +++ b/tests/fate/hevc.mak
> >>>>>> @@ -273,6 +273,16 @@ FATE_HEVC-$(call FRAMECRC, HEVC, HEVC, HEVC_PARSER
> SCALE_FILTER) += fate-hevc-sm
> >>>>>>   fate-hevc-mv-nuh-layer-id: CMD = framecrc -i
> $(TARGET_SAMPLES)/hevc/mv_nuh_layer_id.bit -map 0:view:all
> >>>>>>   FATE_HEVC-$(call FRAMECRC, HEVC, HEVC) += fate-hevc-mv-nuh-layer-id
> >>>>>>
> >>>>>> +# NB: $\ at the end of line joins lines without adding whitespace;
> >>>>>> +# this trick is recommended by GNU make manual
> >>>>>> +fate-hevc-mv-switch: INPUT = \
> >>>>>> +$(TARGET_SAMPLES)/hevc-conformance/LS_A_Orange_2.bit|$\
> >>>>>> +$(TARGET_SAMPLES)/hevc/mv_nuh_layer_id.bit|$\
> >>>>>> +$(TARGET_SAMPLES)/hevc-conformance/NoOutPrior_B_Qualcomm_1.bit|$\
> >>>>>> +$(TARGET_SAMPLES)/hevc-conformance/MVHEVCS_A.bit
> >>>>>> +fate-hevc-mv-switch: CMD = framecrc -i "concat:$(INPUT)" -fps_mode
> passthrough -map 0:vidx:0 -map 0:vidx:1
> >>>>>> +FATE_HEVC-$(call FRAMECRC, HEVC, HEVC, CONCAT_PROTOCOL) += fate-hevc-
> mv-switch
> >>>>>
> >>>>> The test failed when run with msys2, because msys2 only convert the
> first sample path to Windows style path:
> >>>
> >>> It shouldn't convert any at all.
> >>>
> >>>>
> >>>> [in#0 @ 0000028FF3412EC0] Error opening input: No such file or directory
> >>>> Error opening input file
> >>> concat;D:\bin\msys\home\quink\work\ffmpeg-fate-sample\hevc-
> conformance\LS_A_Orange_2.bit|\home\quink\work\ffmpeg-fate-sam
> >>> ple\hevc\mv_nuh_layer_id.bit|\home\quink\work\ffmpeg-fate-sample\hevc-
> conformance\NoOutPrior_B_Qualcomm_1.bit|\home\quin
> >>> k\work\ffmpeg-fate-sample\hevc-conformance\MVHEVCS_A.bit.
> >>>
> >>> I can't reproduce this on msys2 locally. Have you tried using a relative
> >>> path for SAMPLES?
> >> Doesn't work.
> >> [in#0 @ 000001354318E3C0] Error opening input: No such file or directory
> >> Error opening input file concat;..\..\ffmpeg-fate-sample\hevc-
> conformance\LS_A_Orange_2.bit|..\..\ffmpeg-fate-
> sample\hevc\mv_nuh_layer_id.bit|..\..\ffmpeg-fate-sample\hevc-
> conformance\NoOutPrior_B_Qualcomm_1.bit|..\..\ffmpeg-fate-sample\hevc-
> conformance\MVHEVCS_A.bit.
> >> Error opening input files: No such file or directory
> >> threads=1
> >> ffmpeg source code is at $HOME/work/ffmpeg.
> >> Build directory is $HOME/work/ffmpe/build.
> >> Fate sample is at $HOME/work/ffmpeg-fate-sample.
> >> The only workaround I found is copy fate sample to
> $HOME/work/ffmpe/build/ffmpeg-fate-sample, without absolute path or relative
> path prefix.
> >
> > Are you compiling using the mingw64, mingw32, clang64 or clang32 environment
> (And the corresponding gcc/clang package), or directly using the msys2
> environment and its gcc/clang package? Because you should not use the latter.
> 
> I’m using ucrt environment with MSVC compiler, started from visual studio
> developer command line promote.
> 

Hi Zhao and James,

I encountered the same issue, specifically when working in MSYS2 shell directly.
My patch "[PATCH 3/3] tests/hevc: Fix concat input when running in MSYS2 shell"
from today fixes this.

Best,
sw