[FFmpeg-devel] [PATCH] avfilter/vf_libplacebo: add shader_cache_dir option

[Niklas Haas]

On Thu, 15 May 2025 13:08:12 +0200 Andreas Rheinhardt <andreas.rheinhardt at outlook.com> wrote:
> Why do you set the default to "" instead of NULL? This gives an
> allocation even when the option is never set and makes the check for
> whether it is set unnecessarily complicated.

I can change the default to NULL, but I would prefer to keep the check for an
empty string, just to prevent IMO unexpected behavior.

(When the intent is to write cache files to the current working directory, I
think it is better for users to set it to e.g. "./" explicitly.)

>
> > +#endif
> >
> >      {"colorspace", "select colorspace", OFFSET(colorspace), AV_OPT_TYPE_INT, {.i64=-1}, -1, AVCOL_SPC_NB-1, DYNAMIC, .unit = "colorspace"},
> >      {"auto", "keep the same colorspace",  0, AV_OPT_TYPE_CONST, {.i64=-1},                          INT_MIN, INT_MAX, STATIC, .unit = "colorspace"},
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".