[FFmpeg-devel] [PATCH v2 6/7] checkasm: hevc sao_edge, benchmarking inside the width loop is meaningless

[Nuo Mi]

On Thu, May 15, 2025 at 9:05 AM softworkz . <softworkz at hotmail.com> wrote:

>
>
> > -----Original Message-----
> > From: ffmpeg-devel <ffmpeg-devel-bounces at ffmpeg.org> On Behalf Of Nuo Mi
> > Sent: Samstag, 3. Mai 2025 11:13
> > To: ffmpeg-devel at ffmpeg.org
> > Cc: Nuo Mi <nuomi2021 at gmail.com>
> > Subject: [FFmpeg-devel] [PATCH v2 6/7] checkasm: hevc sao_edge,
> benchmarking
> > inside the width loop is meaningless
> >
> > ---
> >  tests/checkasm/hevc_sao.c | 14 +++++++-------
> >  1 file changed, 7 insertions(+), 7 deletions(-)
> >
> > diff --git a/tests/checkasm/hevc_sao.c b/tests/checkasm/hevc_sao.c
> > index ad47423f10..f597eb5254 100644
> > --- a/tests/checkasm/hevc_sao.c
> > +++ b/tests/checkasm/hevc_sao.c
> > @@ -119,21 +119,21 @@ static void check_sao_edge(HEVCDSPContext *h, int
> > bit_depth)
> >          declare_func(void, uint8_t *dst, const uint8_t *src, ptrdiff_t
> > stride_dst,
> >                       const int16_t *sao_offset_val, int eo, int width,
> int
> > height);
> >
> > -        for (int w = prev_size + 4; w <= block_size; w += 4) {
> > -            randomize_buffers(src0, src1, BUF_SIZE);
> > -            randomize_buffers2(offset_val, OFFSET_LENGTH);
> > -            memset(dst0, 0, BUF_SIZE);
> > -            memset(dst1, 0, BUF_SIZE);
> > +        if (check_func(h->sao_edge_filter[i], "hevc_sao_edge_%d_%d",
> > block_size, bit_depth)) {
> > +            for (int w = prev_size + 4; w <= block_size; w += 4) {
> > +                randomize_buffers(src0, src1, BUF_SIZE);
> > +                randomize_buffers2(offset_val, OFFSET_LENGTH);
> > +                memset(dst0, 0, BUF_SIZE);
> > +                memset(dst1, 0, BUF_SIZE);
> >
> > -            if (check_func(h->sao_edge_filter[i], "hevc_sao_edge_%d_%d",
> > block_size, bit_depth)) {
> >                  call_ref(dst0, src0 + offset, stride, offset_val, eo, w,
> > block_size);
> >                  call_new(dst1, src1 + offset, stride, offset_val, eo, w,
> > block_size);
> >                  for (int j = 0; j < block_size; j++) {
> >                      if (memcmp(dst0 + j*stride, dst1 + j*stride,
> > w*SIZEOF_PIXEL))
> >                          fail();
> >                  }
> > -                bench_new(dst1, src1 + offset, stride, offset_val, eo,
> > block_size, block_size);
> >              }
> > +            bench_new(dst1, src1 + offset, stride, offset_val, eo,
> > block_size, block_size);
> >          }
> >      }
> >  }
> > --
>
> Hi Nuo,
>
> since you have applied this patch (or 7/7)´today, both FATE builds on
> Windows
> (MSVC + GCC) are failing - for all submitted patches.
>
> https://patchwork.ffmpeg.org/project/ffmpeg
>
>
> Could you please take a look?
>

Your CI is great!👍
Should fixed by
https://patchwork.ffmpeg.org/project/ffmpeg/patch/20250515124603.42691-1-nuomi2021@gmail.com/


>
>
>
>
> With MSVC:
>
> D:\a\1\s\libavcodec\get_bits.h(366): warning C4101: 're_cache':
> unreferenced local variable
> vvc_alf.c
> CC      tests/checkasm/vp9dsp.o
> vp9dsp.c
> D:\a\1\s\libavcodec\get_bits.h(366): warning C4101: 're_cache':
> unreferenced local variable
> STRIP   tests/checkasm/x86/checkasm.o
> skipping strip -x tests/checkasm/x86/checkasm.o
> CC      tests/checkasm/vvc_sao.o
> vvc_sao.c
> D:\a\1\s\libavcodec\get_bits.h(366): warning C4101: 're_cache':
> unreferenced local variable
> D:\a\1\s\libavcodec\get_bits.h(366): warning C4101: 're_cache':
> unreferenced local variable
> C:\Program Files (x86)\Windows
> Kits\10\\include\10.0.26100.0\\um\winnt.h(21227): error C2143: syntax
> error: missing ':' before 'constant'
> C:\Program Files (x86)\Windows
> Kits\10\\include\10.0.26100.0\\um\winnt.h(21227): error C2143: syntax
> error: missing ';' before ':'
> C:\Program Files (x86)\Windows
> Kits\10\\include\10.0.26100.0\\um\winnt.h(21227): error C2059: syntax
> error: ':'
> C:\Program Files (x86)\Windows
> Kits\10\\include\10.0.26100.0\\um\winnt.h(21228): error C2143: syntax
> error: missing '{' before ':'
> C:\Program Files (x86)\Windows
> Kits\10\\include\10.0.26100.0\\um\winnt.h(21228): error C2059: syntax
> error: ':'
> make: *** [ffbuild/common.mak:81: tests/checkasm/vvc_sao.o] Error 2
> C:\Program Files (x86)\Windows
> Kits\10\\include\10.0.26100.0\\um\winnt.h(21229): error C2059: syntax
> error: '}'
> C:\Program Files (x86)\Windows
> Kits\10\\include\10.0.26100.0\\um\winnt.h(21230): error C2059: syntax
> error: '}'
> C:\Program Files (x86)\Windows
> Kits\10\\include\10.0.26100.0\\um\winnt.h(21231): error C2059: syntax
> error: '}'
>
>
> https://dev.azure.com/githubsync/ffmpeg/_build/results?buildId=87858&view=logs
>
>
> With GCC:
>
> CC      tests/checkasm/vf_threshold.o
> CC      tests/checkasm/videodsp.o
> CC      tests/checkasm/vorbisdsp.o
> CC      tests/checkasm/vp8dsp.o
> CC      tests/checkasm/vp9dsp.o
> CC      tests/checkasm/vvc_alf.o
> CC      tests/checkasm/vvc_mc.o
> CC      tests/checkasm/vvc_sao.o
> X86ASM  tests/checkasm/x86/checkasm.o
> CC      tests/api/api-threadmessage-test.o
> In file included from ./libavcodec/vvc/ctu.h:31,
>                  from tests/checkasm/vvc_sao.c:27:
> ./libavcodec/vvc/dec.h:36:33: error: expected identifier or '(' before
> numeric constant
>    36 | #define CR                      2
>       |                                 ^
> make: *** [ffbuild/common.mak:81: tests/checkasm/vvc_sao.o] Error 1
> CC      tests/api/api-flac-test.o
> CC      tests/api/api-seek-test.o
> HOSTCC  tests/audiogen.o
> STRIP   tests/checkasm/x86/checkasm.o
> HOSTCC  tests/videogen.o
> CC      libavcodec/tests/apv.o
> CC      libavcodec/tests/avpacket.o
> CC      libavcodec/tests/bitstream_be.o
>
>
> https://dev.azure.com/githubsync/ffmpeg/_build/results?buildId=87859&view=logs
>
>
> Thanks,
> sw
>