[FFmpeg-devel] [PATCH] avcodec/utvideoenc: Don't advertise unsupported option
Andreas Rheinhardt
andreas.rheinhardt at outlook.com
Fri May 16 23:02:46 EEST 2025
Jan Ekström:
> On Fri, May 16, 2025 at 5:19 PM Andreas Rheinhardt
> <andreas.rheinhardt at outlook.com> wrote:
>>
>> Patch attached.
>>
>
> LGTM.
>
> Seems like as part of moving prediction method from codec context to
> private options in 2862b63783b5556f7f3fb2d097629bc6879f833a the
> gradient value was kept as an alternative, even though even then it
> was just being checked against.
>
> If the value was not in the middle in UtVideo, I would note that it
> may have made sense to just drop any references or checking for this
> value from utvideoenc, but alas I don't think that's possible?
>
It would be possible to use encoder-specific constants for the option
and translate this to the codec-specific ones that get written in the
file. Users that only set the prediction method via the strings (like
"-pred median") would not be affected, but users using the
codec-specific numerical values would be.
I opted for the minimal change in my patch.
- Andreas
More information about the ffmpeg-devel
mailing list