[Mplayer-advusers] pre-bugreport

[Michael Niedermayer]

Hi

On Tuesday 16 March 2004 09:23, D Richard Felker III wrote:
> On Mon, Mar 15, 2004 at 07:13:50PM +0100, Michael Niedermayer wrote:
> > Hi
> >
> > On Monday 15 March 2004 18:55, Arpi wrote:
> > > Hi,
> > >
> > > > > if you cannot reproduce, i'll investigate further...
> > > >
> > > > its known problem, the last line is converted with the c converter
> > > > while the rest is done in mmx, alex changed the rgb<->bgr behavior of
> > > > the c code sometime ago, and after some complaints by me, alex
> > > > summarized how rgb and bgr should be defined, and IMHO the definition
> > > > is good its just not what most of the code in mplayer currently uses,
> > > > so IIRC the mmx code matches your definition of rgb/bgr while the c
> > > > code matches alexs :)
> > >
> > > "cool".
> > > any chance to fix it anyway?
> >
> > patch attached, i wont commit, as i dont want to be flamed :)
>
> Are you sure this patch is correct? IMO the depth reading is
#define IMGFMT_RGB_DEPTH(fmt) ((fmt)&0x3F)
#define IMGFMT_BGR_DEPTH(fmt) ((fmt)&0x3F)

>
> incorrect:
> > -    const int isRgb = IMGFMT_IS_RGB(c->dstFormat);
> > +    const int isRgb = !IMGFMT_IS_RGB(c->dstFormat);
> >      const int bpp =
> > isRgb?IMGFMT_RGB_DEPTH(c->dstFormat):IMGFMT_BGR_DEPTH(c->dstFormat);
>
> The last line should be:
>
>      const int bpp =
> isRgb?IMGFMT_BGR_DEPTH(c->dstFormat):IMGFMT_RGB_DEPTH(c->dstFormat);
IMHO it should be  
const int bpp = IMGFMT_RGB_DEPTH(c->dstFormat);

[...]
-- 
Michael
level[i]= get_vlc(); i+=get_vlc();		(violates patent EP0266049)
median(mv[y-1][x], mv[y][x-1], mv[y+1][x+1]);	(violates patent #5,905,535)
buf[i]= qp - buf[i-1];				(violates patent #?)
for more examples, see http://mplayerhq.hu/~michael/patent.html
stop it, see http://petition.eurolinux.org & http://petition.ffii.org/eubsa/en