[MPlayer-advusers] [BUG] parallel make fails

[Dominik 'Rathann' Mierzejewski]

On Friday, 13 January 2006 at 22:04, Oded Shimon wrote:
> On Fri, Jan 13, 2006 at 10:01:37PM +0100, Guillaume POIRIER wrote:
> > Hi,
> > 
> > On 1/13/06, Dominik 'Rathann' Mierzejewski <dominik at rangers.eu.org> wrote:
> > > Calling for Makefile/buildsystem gurus!
> > >
> > > This is very hard to reproduce, but sometimes build fails due to
> > > vidix/drivers being compiled befor libdha is built. Consequently,
> > > linking with libdha fails.
> > >
> > > I managed to reproduce this once by doing a full build, and then:
> > > $ make -C libdha clean
> > > $ make -C vidix clean
> > > $ make -j
> > >
> > > Anyone?
> > 
> > Parallel build pretty much never worked for me... now, what could be the cure ?
> > I don't have the faintest idea.
> 
> Please report if thise solves.
> 
> - ods15

> Index: Makefile
> ===================================================================
> RCS file: /cvsroot/mplayer/main/Makefile,v
> retrieving revision 1.333
> diff -u -r1.333 Makefile
> --- Makefile	16 Nov 2005 10:38:23 -0000	1.333
> +++ Makefile	13 Jan 2006 21:04:28 -0000
> @@ -336,7 +336,7 @@
>  libdha/libdha.so:
>  	$(MAKE) -C libdha
>  
> -vidix/libvidix.a:
> +vidix/libvidix.a: libdha/libdha.so
>  	$(MAKE) -C vidix
>  
>  Gui/libgui.a:

Looks correct (that's what I had in mind more or less) and looks like it
fixes the problem. I'm unable to reproduce it anymore.

I'll commit it right away.

I've noticed that there is a similar (although larger) problem with the
docs, too.

Regards,
R.

-- 
MPlayer RPMs maintainer: http://rpm.greysector.net/mplayer/
"I am Grey. I stand between the candle and the star. We are Grey.
 We stand between the darkness ... and the light."
        -- Delenn in Grey Council in Babylon 5:"Babylon Squared"