[Mplayer-cvslog] CVS: main/libao2 ao_plugin.c,1.4,1.5 [BREAKS /w gcc3]

[pl]

On Tue, Dec 04, 2001 at 01:23:29PM +0100, Anders Johansson wrote:
> Update of /cvsroot/mplayer/main/libao2
> In directory mplayer:/var/tmp.root/cvs-serv18543/libao2
> 
> Modified Files:
> 	ao_plugin.c 
> Log Message:
> Global variables protected using volatile
This breaks CVS (types not matching in audio_plugin.h) with gcc3.

Is 'volatile' attribute really needed (as values are used in a
sequential way [no thread, no signals]) ?


> 
> Index: ao_plugin.c
> ===================================================================
> RCS file: /cvsroot/mplayer/main/libao2/ao_plugin.c,v
> retrieving revision 1.4
> retrieving revision 1.5
> diff -u -r1.4 -r1.5
> --- ao_plugin.c	3 Dec 2001 14:04:55 -0000	1.4
> +++ ao_plugin.c	4 Dec 2001 12:23:27 -0000	1.5
> @@ -30,11 +30,11 @@
>    ao_plugin_functions_t* available_plugins[NPL]; // List of available plugins
>  } ao_plugin_local_data_t;
>  
> -ao_plugin_local_data_t ao_plugin_local_data={NULL,NULL,AO_PLUGINS};
> +static ao_plugin_local_data_t ao_plugin_local_data={NULL,NULL,AO_PLUGINS};
>  
>  // gloabal data 
       ~~~ (typo should you change these lines)
> -ao_plugin_data_t ao_plugin_data; // data used by the plugins
> -ao_plugin_cfg_t  ao_plugin_cfg=CFG_DEFAULTS;  // cfg data set in cfg-mplayer.h
> +volatile ao_plugin_data_t ao_plugin_data; // data used by the plugins
> +volatile ao_plugin_cfg_t  ao_plugin_cfg=CFG_DEFAULTS;  // cfg data set in cfg-mplayer.h
>  
>  // to set/get/query special features/parameters
>  static int control(int cmd,int arg){
> 
> _______________________________________________
> Mplayer-cvslog mailing list
> Mplayer-cvslog at mplayerhq.hu
> http://mplayerhq.hu/mailman/listinfo/mplayer-cvslog
> 

-- 
Best regards,
  pl