[Mplayer-cvslog] CVS: main/postproc rgb2rgb.c,1.22,1.23 rgb2rgb.h,1.9,1.Mon Nov 5 14:12:12 2001

[Nick Kurshev]

Hello, Arpi!
On Mon, 5 Nov 2001 14:13:15 +0200 (CEST), you wrote:

> Hi,
> 
> > >
> > > -		((uint16_t *)dst)[i]= (b>>3) | ((g&0xFC)<<3) | ((r&0xF8)<<8);
> > > +		*((uint16_t *)dst) = (b>>3) | ((g&0xFC)<<3) | ((r&0xF8)<<8);
> > > +		dst+=2;
> > > +		s++;
> > >  	}
> > >  }
> > this is inacceptable, it is harder to read and very likely slower (arrays 
> > tend to be faster than pointers)
> > 
> > did u try a -benchmark? if not than please reverse this change
> 
> Agree. i've reversed Nick's last patch.
> 
It makes this stuff unusable in vo_vesa, btw.
Then reverse vo_vesa last update too, since these functions has incompatible interface
> 
> A'rpi / Astral & ESP-team
> 
> --
> mailto:arpi at thot.banki.hu
> http://esp-team.scene.hu
> _______________________________________________
> Mplayer-cvslog mailing list
> Mplayer-cvslog at mplayerhq.hu
> http://mplayerhq.hu/mailman/listinfo/mplayer-cvslog
> 


Best regards! Nick