[Mplayer-cvslog] CVS: main/libmpcodecs vd_ffmpeg.c,1.45,1.46

[Michael Niedermayer]

Hi

On Thursday 29 August 2002 00:21, Arpi wrote:
> Hi,
>
> > > > +    if(   sh->format == mmioFOURCC('R', 'V', '1', '0')
> > > > +       || sh->format == mmioFOURCC('R', 'V', '1', '3')){
> > > > +        unsigned int* extrahdr=(unsigned int*)(sh->bih+1);
> > > > +        avctx->extradata_size= 8;
> > > > +	avctx->extradata = malloc(avctx->extradata_size);
> > >
> > > hmm you could just do avctx->extradata = (sh->bih+1);
> > > it won't be free'd until decoding ends so no need to duplicate
> >
> > hmm unsigned int and 64bit architectures ...
>
> hmm it won't work anyway :(
>
>    sh->bih = malloc(sizeof(BITMAPINFOHEADER)+8);
>
> so it should be fixed in demux_real instead of workarounds in vd_ffmpeg
>
> btw where is 'unsigned int' 64bit long?
> afaik int is 16/32/32 bit, long is 32/32/64 bit depending on arch 16/32/64
hmm, oops, i think i need to find some cola or perhaps RTFCStandart a bit more 
;)
but uint32_t is needed anyway for 16bit support :)))))

[...]

Michael