[Mplayer-cvslog] CVS: main/libvo vo_x11.c,1.56,1.57

[Michael Niedermayer]

Hi

On Wednesday 06 February 2002 18:09, Nick Kurshev wrote:
[...]
> > -vo vesa -vc divx4 (useing i420 -> BGR16) looks ok to me, whats wrong?
>
> I test it with -vc divxds
i didnt know that divxds supports i420 ...

> It doesn't swap U and V planes.
dunno divxds with i420 segfaults with any vo here

> So there is the same effect as hue=+1000 on radeons ;)
> You've fixed vo_x11 driver but vesa already doesn't use yuv2rgb and rgb2rgb
yuvrgb is faster if there is no scaling done, hmm, perhaps the scaler should 
internally use yuv2rgb / rgb2rgb if possible

> functions. vesa driver uses swScale for every purpose. So I can't fix that
> similar to vo_x11 and this lack should be fixed within of your swScale
> code.
> Also there don't work rgb2rgb code (swScaleInit returns error code for such
swScale can currently handle bgr24 & bgr32 input, it cannot handle bgr15 / 
bgr16 input and bgr input is mostly a hack not really useable as its 
converted to yv12 before scaling and that is done in plain C no mmx yet ...

> cases.) Also when I use -screenw 800 -x 700 (initial width 544) I have
> right vertical green line for any fourcc with swScale.
damn, not these green lines again ;)

[...]

Michael