[Mplayer-cvslog] CVS: main/vidix/drivers mga_vid.c,1.8,1.9

[Nick Kurshev]

Hello, Alex!

On Sun, 20 Jan 2002 00:59:23 +0100 you wrote:

> Update of /cvsroot/mplayer/main/vidix/drivers
> In directory mplayer:/var/tmp.root/cvs-serv14908
> 
> Modified Files:
> 	mga_vid.c 
> Log Message:
> equalizer is only supported by g400
> 
> Index: mga_vid.c
> ===================================================================
> RCS file: /cvsroot/mplayer/main/vidix/drivers/mga_vid.c,v
> retrieving revision 1.8
> retrieving revision 1.9
> diff -u -r1.8 -r1.9
> --- mga_vid.c	19 Jan 2002 22:46:28 -0000	1.8
> +++ mga_vid.c	19 Jan 2002 23:59:20 -0000	1.9
> @@ -1461,7 +1461,11 @@
>  	if(contrast < 0)   contrast = 0;
>  	if(contrast > 255) contrast = 255;
>  	beslumactl = ((brightness & 0xff) << 16) | (contrast & 0xff);
> +
> +    if (is_g400)
>  	writel(beslumactl,mga_mmio_base + BESLUMACTL);
> +    else
> +	printf("[mga] equalizer isn't supported with G200\n");
>      return 0;
>  }
>  
I guess you shouldn't print out this message every time.
It would be enough to adjust this by flags.
IMHO - you should suppress this printf.
> 
> _______________________________________________
> Mplayer-cvslog mailing list
> Mplayer-cvslog at mplayerhq.hu
> http://mplayerhq.hu/mailman/listinfo/mplayer-cvslog
> 


Best regards! Nick