[Mplayer-cvslog] CVS: main/libmpcodecs vd_ffmpeg.c,1.26,1.27

Arpi arpi at thot.banki.hu
Sun Jul 14 23:45:55 CEST 2002


Hi,

> + 
> +    if(vo_directrendering && lavc_codec->capabilities&CODEC_CAP_DR1)
> +	ctx->do_dr1=1;

hmm. a codec shouldn't depend on vo_directrendering. it's used by vo wrapper.
why? even if user don't want/use -dr, direct rendering could be used between
codecs and filters. disabling -dr (and having it as default) has 2 reasons:
- many vo driver has bugs, problems with -dr (like flickering osd)
- some vo drivers with some codec/filter combinations are slower with -dr
  (for example, vf_expand to vram is fast, but libmpeg2 decoding or pp to
  vram are slow as hell)


A'rpi / Astral & ESP-team

--
Developer of MPlayer, the Movie Player for Linux - http://www.MPlayerHQ.hu



More information about the MPlayer-cvslog mailing list