[Mplayer-cvslog] CVS: main/libmpcodecs vf_noise.c,1.1,1.2

[Arpi]

Hi,

> direct rendering (hopefully at least, TFM for the video filters is a bit non
> existent or iam just too stupid) ;)

hmm i should write some (more) docs :)
until now i was the only one writting/porting such filters

isn't this noise rendering is something like
dst_pixel[x,y]=src_pixel[x,y]+noise_func(x,y) ?

so i can't see where can DR helps...

with this get_image(), the codec will render image to the dest buffer,
then you do dst_pixel[x,y]+=noise_func(x,y)... why is it better?
maybe it's even slower... especially if dst_* is in video ram

> +    if(!(mpi->flags&MP_IMGFLAG_ACCEPT_STRIDE) && mpi->imgfmt!=vf->priv->out
> fmt)

imho that && should be ||
and that mpi->flags&MP_IMGFLAG_ACCEPT_STRIDE is not needed at all, just pass
these flags to the vf_get_image here, as you do now:

> +	return; // colorspace differ
> +    // ok, we can do pp in-place (or pp disabled):
> +    vf->priv->dmpi=vf_get_image(vf->next,mpi->imgfmt,
> +        mpi->type, mpi->flags, mpi->w, mpi->h);

also note, that mpi->type may be EXPORT, where this won't work imho


A'rpi / Astral & ESP-team

--
Developer of MPlayer, the Movie Player for Linux - http://www.MPlayerHQ.hu