[Mplayer-cvslog] CVS: main/postproc swscale.c,1.91,1.92 swscale_template.c,1.78,1.79

[Nick Kurshev]

Hello, Michael!

On Sat, 22 Jun 2002 22:37:39 +0200 you wrote:

> Update of /cvsroot/mplayer/main/postproc
> In directory mail:/var/tmp.root/cvs-serv29892
> 
> Modified Files:
> 	swscale.c swscale_template.c 
> Log Message:
> 
> cleanup & grayscale support
> 
> 
> Index: swscale.c
> ===================================================================
> RCS file: /cvsroot/mplayer/main/postproc/swscale.c,v
> retrieving revision 1.91
> retrieving revision 1.92
> diff -u -r1.91 -r1.92
> --- swscale.c	22 Jun 2002 08:49:45 -0000	1.91
> +++ swscale.c	22 Jun 2002 20:37:30 -0000	1.92
> @@ -18,7 +18,7 @@
>  
>  /*
>    supported Input formats: YV12, I420, IYUV, YUY2, BGR32, BGR24, BGR16, BGR15, RGB32, RGB24, Y8, Y800
> -  supported output formats: YV12, I420, IYUV, BGR15, BGR16, BGR24, BGR32 (grayscale soon too)
> +  supported output formats: YV12, I420, IYUV, BGR15, BGR16, BGR24, BGR32, Y8, Y800
>    BGR15/16 support dithering
>    
>    unscaled special converters
> @@ -100,26 +100,21 @@
>  #endif
>  
>  //FIXME replace this with something faster
> -#define isBGR(x)       ((x)==IMGFMT_BGR32|| (x)==IMGFMT_BGR24|| (x)==IMGFMT_BGR16|| (x)==IMGFMT_BGR15)
> -#define isRGB(x)       ((x)==IMGFMT_RGB32|| (x)==IMGFMT_RGB24|| (x)==IMGFMT_RGB16|| (x)==IMGFMT_RGB15)
> -#define isPlanarYUV(x) ((x)==IMGFMT_YV12 || (x)==IMGFMT_I420 || (x)==IMGFMT_IYUV|| (x)==IMGFMT_YVU9 || (x)==IMGFMT_IF09)
> -#define isYUV(x)       (!(isBGR(x) || isRGB(x)))
> -#define isHalfChrV(x)  ((x)==IMGFMT_YV12 || (x)==IMGFMT_I420 || (x)==IMGFMT_IYUV)
> +#define isPlanarYUV(x) ((x)==IMGFMT_YV12 || (x)==IMGFMT_I420 || (x)==IMGFMT_YVU9)
> +#define isYUV(x)       ((x)==IMGFMT_YUY2 || isPlanarYUV(x))
I really don't understand why you've ignored other packed foourccs.
IMHO my version was (is in mplayerxp) better
> +#define isHalfChrV(x)  ((x)==IMGFMT_YV12 || (x)==IMGFMT_I420)
What about everything which was below - I use swScaler as universal blitter )in my dri_vo output)
and have tuned many things which were destroyed by your commit.
> _______________________________________________
> Mplayer-cvslog mailing list
> Mplayer-cvslog at mplayerhq.hu
> http://mplayerhq.hu/mailman/listinfo/mplayer-cvslog
> 


Best regards! Nick
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-cvslog/attachments/20020624/9e328113/attachment.pgp>