[Mplayer-cvslog] Re: CVS: main/libmpcodecs ve_xvid.c,1.2,1.3

[Rémi Guyomarch]

On Sun, Nov 03, 2002 at 04:54:44PM +0100, Kim Minh Kaplan wrote:
> RXmi Guyomarch CVS writes:
> 
> > coding style etc...:
> > - Use static variables instead of a big struct for individual options,
> > easier to initialize.
> 
> Why do this?  This is more a step backward than forward.  Global
> variables are a plague, and at one time or another we'll end up trying
> to get rid of them.

Well, I think it's easier to see which variable is initialized by
which value. We could move them inside config() if you prefer, and
move the few variables which need to be accessible in other parts in
vf_priv_s, but this will bloat the code.
Since these variables are declared static, they won't clash with
others declared elsewhere.

-- 
Rémi