[Mplayer-cvslog] CVS: main/libmpdemux audio_in.c,1.6,1.7 demux_asf.c,1.25,1.26 demux_avi.c,1.51,1.52 demux_mov.c,1.82,1.83 demux_mpg.c,1.45,1.46 demux_pva.c,1.3,1.4 demux_real.c,1.33,1.34 demux_viv.c,1.23,1.24 tv.c,1.39,1.40 tvi_v4l.c,1.40,1.41

Alex Beregszaszi alex at naxine.org
Sat Nov 23 18:41:03 CET 2002


Hi,

> > > > >  	    case MOV_FOURCC('s','t','t','s'): {
> > > > > -		int temp=stream_read_dword(demuxer->stream);
> > > > > +		stream_read_dword(demuxer->stream);
> > > >
> > > > 1000L !
> > > > reverse this file !
> > >
> > > ok, but could u explain why it is bad? i cant see where temp is used ...
> >
> > it's not used but at least my gcc 2.95.4 didn't support declaring variables
> > after some func calls. so:
> > {
> > stream_read_dword(demuxer->stream);
> > int len = stream_read_dword(demuxer->stream);
> > }
> > is bad.
> ooooooops, thats really 1000l
> only strange is that gcc 3.2 did compile it
gcc 3.2 is more non-ansi compatible in that way, it supports c++ things
in c too. (like first was the C++ comment (//) support years ago, and now this ;)

probably with -ansi -pedantic it should fail too

-- 
Alex Beregszaszi  <alex at naxine.org>
(MPlayer Core Developer -- http://www.mplayerhq.hu/)



More information about the MPlayer-cvslog mailing list