[Mplayer-cvslog] CVS: main/libmpdemux asf_streaming.c,1.31,1.32

[D Richard Felker III]

On Sat, Sep 07, 2002 at 10:38:47PM +0200, Bertrand Baudet wrote:
> Update of /cvsroot/mplayer/main/libmpdemux
> In directory mail:/var/tmp.root/cvs-serv8593
> 
> Modified Files:
> 	asf_streaming.c 
> Log Message:
> Don't try to reread from the socket if the server says EOF
> 
> 
> Index: asf_streaming.c
> ===================================================================
> RCS file: /cvsroot/mplayer/main/libmpdemux/asf_streaming.c,v
> retrieving revision 1.31
> retrieving revision 1.32
> diff -u -r1.31 -r1.32
> --- asf_streaming.c	3 Sep 2002 01:32:13 -0000	1.31
> +++ asf_streaming.c	7 Sep 2002 20:38:44 -0000	1.32
> @@ -660,7 +660,7 @@
>  		do {
>  			i = read( fd, buffer, BUFFER_SIZE );
>  //printf("read: %d\n", i );
> -			if( i<0 ) {
> +			if( i<=0 ) {
>  				perror("read");

Hmm, perror uses errno to print the error. AFAIK, errno is not set on
eof, since it's not an error condition, so this could confuse users
with a misleading errno from a previous error somewhere else, or a
message like: "read: Success".

Rich