[Mplayer-cvslog] CVS: main/libvo x11_common.c,1.99,1.100

Arpi of Ize arpi at mplayerhq.hu
Sun Sep 29 00:37:32 CEST 2002


Update of /cvsroot/mplayer/main/libvo
In directory mail:/var/tmp.root/cvs-serv1585

Modified Files:
	x11_common.c 
Log Message:
fullscreen fixes, based on mail by Havoc Pennington <hp at redhat.com>
  - it should not set _NET_WM_STATE_STAYS_ON_TOP, this hint does
    not exist in the spec
    (http://www.freedesktop.org/standards/wm-spec/1.2/html/x224.html)
    and _NET_WM_STATE_FULLSCREEN already implies "on top" so there's no
    need to set this.
    it should set _NET_WM_STATE_FULLSCREEN instead, I don't
    currently see code to set _NET_WM_STATE_FULLSCREEN
  - the XUnmapWindow() after sending the client message
    is officially speaking breaking the spec, should be
    XWithdrawWindow().


Index: x11_common.c
===================================================================
RCS file: /cvsroot/mplayer/main/libvo/x11_common.c,v
retrieving revision 1.99
retrieving revision 1.100
diff -u -r1.99 -r1.100
--- x11_common.c	23 Sep 2002 21:17:30 -0000	1.99
+++ x11_common.c	28 Sep 2002 22:37:20 -0000	1.100
@@ -667,7 +667,8 @@
    e.xclient.window=vo_window;
    e.xclient.format=32;
    e.xclient.data.l[0]=layer;
-   e.xclient.data.l[1]=XInternAtom( mDisplay,"_NET_WM_STATE_STAYS_ON_TOP",False );
+//   e.xclient.data.l[1]=XInternAtom( mDisplay,"_NET_WM_STATE_STAYS_ON_TOP",False );
+   e.xclient.data.l[1]=XInternAtom( mDisplay,"_NET_WM_STATE_FULLSCREEN",False );
    XSendEvent( mDisplay,mRootWin,False,SubstructureRedirectMask,&e );
 								   
    XFree( args );
@@ -723,7 +724,8 @@
  vo_x11_sizehint( x,y,w,h,0 );
  vo_x11_setlayer( vo_fs );
  if(vo_wm_type==vo_wm_Unknown && !(vo_fsmode&16))
-     XUnmapWindow( mDisplay,vo_window );  // required for MWM
+//     XUnmapWindow( mDisplay,vo_window );  // required for MWM
+    XWithdrawWindow(mDisplay,vo_window,mScreen);
  XMoveResizeWindow( mDisplay,vo_window,x,y,w,h );
 #ifdef HAVE_XINERAMA
  vo_x11_xinerama_move(mDisplay,vo_window);




More information about the MPlayer-cvslog mailing list