[Mplayer-cvslog] CVS: main configure,1.740,1.741

[D Richard Felker III]

On Tue, Aug 05, 2003 at 12:46:26AM +0200, Diego Biurrun wrote:
> D Richard Felker III writes:
>  > On Mon, Aug 04, 2003 at 03:21:47PM +0200, Alex Beregszaszi wrote:
>  > > > @@ -3923,6 +3923,14 @@
>  > > >    cc_check $_inc_extra -I$_dvdnavdir $_legal_dvdnavdir -ldvdnav
>  > > >    $_used_css $_ld_dl $_ld_pthread && _dvdnav=yes
>  > > >  fi
>  > > >  if test "$_dvdnav" = yes ; then
>  > > > +  cat <<EOF
>  > > > +
>  > > > +!!! WARNING: DVDNAV DOES NOT WORK!
>  > > > +!!! Do not send bugreports regarding dvdnav support!
>  > > > +!!! If you want dvdnav, wait for MPlayer G2, send a PATCH,
>  > > > +!!! or use a different movie player for DVDs.
>  > > Probably the last line is a bit misleading, what about:
>  > > 'or use a different movie player if you really need _DVD MENU_ support'
>  > 
>  > Feel free to change it. My impression has just been that the people
>  > who insist on trying to enable dvdnav are so neurotic about it that
>  > they absolutely refuse to type mplayer dvd://titleno, so I figured it
>  > they couldn't get dvdnav support they wouldn't want to use mplayer for
>  > dvds at all. But, I agree, it is a little misleading, so go ahead and
>  > change it to something that sounds better.
> 
> Why not simply disable (comment out) dvdnav in configure?  Sounds like
> the most logical option to me.  Whoever wants to toy around with it
> will then have to hack configure.  This will make sure that nobody
> uses it by mistake and blames our "buggy" player..
> 
> I can come up with a patch for that.

Yes, Gabu said the same... So go ahead and do it. Actually that was my
original intent, but i didn't see any easy reversible way to disable
all the stuff without fully removing it from the script, and I wasn't
feeling that brave. :)

Rich