[Mplayer-cvslog] CVS: main/libmpcodecs vd_ffmpeg.c, 1.113, 1.114 mp_image.h, 1.28, 1.29

[Michael Niedermayer]

Hi

On Wednesday 24 December 2003 08:01, D Richard Felker III wrote:
> On Mon, Dec 22, 2003 at 06:26:21PM +0100, Michael Niedermayer CVS wrote:
> > +#if LIBAVCODEC_BUILD >= 4697
> > +    mpi->fields = MP_IMGFIELD_ORDERED;
> > +    if(pic->interlaced_frame) mpi->fields |= MP_IMGFIELD_INTERLACED;
> > +    if(pic->top_field_first ) mpi->fields |= MP_IMGFIELD_TOP_FIRST;
> > +#endif
>
> This is incorrect. MP_IMGFIELD_ORDERED must NOT be set unless field
yes, ill fix it

> order is known! There are many codecs in lavc which do not know field
> order, so it should only be set for the ones that do know field order
> and export it via pic->top_field_first, i.e. only mpeg2...
and mpeg4 and dv
is there any documentation which defines what each MP_IMGFIELD flag means 
exactly?

its a bit strange that ordered is needed at all, as top_field_first has no 
meaning in progressive frames (as progressive frames per definition have the 
same PTS for both field)

...

hmm maybe ORDERED is supposed to means INTERLACED frame? then my addition of 
MP_IMGFIELD_INTERLACED should be reversed ...

[...]
-- 
Michael
level[i]= get_vlc(); i+=get_vlc();		(violates patent EP0266049)
median(mv[y-1][x], mv[y][x-1], mv[y+1][x+1]);	(violates patent #5,905,535)
buf[i]= qp - buf[i-1];				(violates patent #?)
for more examples, see http://mplayerhq.hu/~michael/patent.html
stop it, see http://petition.eurolinux.org & http://petition.ffii.org/eubsa/en