[Mplayer-cvslog] CVS: main/libmpcodecs vf_lavcdeint.c,1.5,1.6

[Filip Kalinski]

On Sat, Jan 04, 2003 at 11:47:07PM +0100, Arpi wrote:
> Hi,
> 
> > Found another 10l :-), but the filter is still broken :-(
> 
> >    /* The deinterlacer will fail if this is false */
> > -  if ((width & 1) != 0 || (height & 3) != 0)
> > +  if ((width & 3) != 0 || (height & 3) != 0)
> >      return 0;
> 
> why is it a bug? imho it was right before you changed it.
> 
> why?  yv12 pixels are 2x2 blocks (4 Y, 1 U, 1 V), but since it
> operates on pairs of lines (deinterlaces) it requires 2x4 pixel blocks.
> so, width&1 and heigt&3 checks were correct.
> 
> ok to reverse? :)
> 

But in function avipicture_deinterlace there is a check "if ((width & 3) != 0
|| (height & 3) != 0)" so it will fail in case of width & 2.

-- 
Filip Kalinski <filon at pld.org.pl>