[Mplayer-cvslog] CVS: main/libmpdemux tvi_v4l.c,1.61,1.62

D Richard Felker III dalias at aerifal.cx
Sun Mar 30 23:35:57 CEST 2003


On Sun, Mar 30, 2003 at 10:32:50PM +0200, Alban Bedel wrote:
> > > +    if(close(priv->video_fd))
> > > +      mp_msg(MSGT_TV, MSGL_ERR, "Close tv failed:
> > > %s\n",strerror(errno));
> > 
> > AFAIK, the only error close can return is "bad fd" (i.e. you passed it
> > a number that's not a fd), so checking for error is probably
> > pointless.
> It's the rest of my search to this bug. Fell free to revert if you think
> it can hurt ;)

I don't think it'll hurt. :) I just posted that comment for reference
so that hopefully no one litters the code with stuff like this all
over the place in the future, but there's no point in removing this
one occurrance.

Rich



More information about the MPlayer-cvslog mailing list